Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment_name param updated to deployment_id #620

Closed
wants to merge 2 commits into from

Conversation

thanseefpp
Copy link
Contributor

openai updated their param as deployment_id

@zzstoatzz
Copy link
Collaborator

hi @thanseefpp

can you explain what you mean when you say this?

openai updated their param as deployment_id

I'll admit I don't know a ton about using the azure flavor of OpenAI, but at a glance it seems like other libraries are using deployment_name, e.g.:

@thanseefpp
Copy link
Contributor Author

sorry, I just saw by now, when I was using the 1.5.4 which includes my recent changes. the openai library with the latest version they have changed the deployment_name param to deployment_id. so when we are keeping the param as deployment_name some abstract methods are raising the same issue. so right now I'm using the old 1.4.2 which is stable and openai==0.28.0 version.

@zzstoatzz
Copy link
Collaborator

thanks for the explanation @thanseefpp ! in case its helpful, here's the docs on azure setup for marvin 2.x

@zzstoatzz zzstoatzz closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants